Orbeon Forms community mailing list

xforms:group/xforms:label/@xhtml:class ignored

Classic

List

Threaded

7 messages Options

Adrian Baker-2

xforms:group/xforms:label/@xhtml:class ignored

If I add a @xhtml:class to the label of a group it doesn't get
translated into the generated html.

Looking at XFormsGroupHandler, it seems the call to getAttributes is
mistakenly passing in the attributes of the xforms:group, not the
xforms:label:
final AttributesImpl labelAttributes = getAttributes(attributes,
"xforms-label", null);

This mean the generated html label doesn't get given the class in the
@xhtml:class attribute on the xforms:label (but instead will incorrectly
get any @xhtml:class declared on the enclosing group).

Looking at the revision history I'd say this was caused by the fix for
#305144
(http://cvs.forge.objectweb.org/cgi-bin/viewcvs.cgi/ops/orbeon/src/java/org/orbeon/oxf/xforms/processor/handlers/XFormsGroupHandler.java.diff?r1=1.3&r2=1.4).
But this must mean the OPS deployment on the orbeon site is pretty old,
since it work's ok on there - so perhaps not?

Adrian

--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws

Adrian Baker-2

Re: xforms:group/xforms:label/@xhtml:class ignored

On a semi-related note, if there isn't already a bug tracker for it there's no handling for help/hint/alert in XFormsGroupHandler.

Is there a way to search across the bugs on the objectweb site? Without it it's pretty difficult to check that I'm not raising already-known issues.

Adrian

Adrian Baker wrote:

If I add a @xhtml:class to the label of a group it doesn't get translated into the generated html.

Looking at XFormsGroupHandler, it seems the call to getAttributes is mistakenly passing in the attributes of the xforms:group, not the xforms:label:
final AttributesImpl labelAttributes = getAttributes(attributes, "xforms-label", null);

This mean the generated html label doesn't get given the class in the @xhtml:class attribute on the xforms:label (but instead will incorrectly get any @xhtml:class declared on the enclosing group).

Looking at the revision history I'd say this was caused by the fix for #305144 (http://cvs.forge.objectweb.org/cgi-bin/viewcvs.cgi/ops/orbeon/src/java/org/orbeon/oxf/xforms/processor/handlers/XFormsGroupHandler.java.diff?r1=1.3&r2=1.4). But this must mean the OPS deployment on the orbeon site is pretty old, since it work's ok on there - so perhaps not?

Adrian

______________________________________________________________________
This email has been scanned by the MessageLabs Email Security System.
For more information please visit http://www.messagelabs.com/email ______________________________________________________________________
--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: [hidden email]
For general help: [hidden email]
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
  

--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws

Adrian Baker-2

Re: xforms:group/xforms:label/@xhtml:class ignored

Anyway, a fix for both these issues is to add

        handleLabelHintHelpAlert(effectiveGroupId, "label", groupXFormsControl);
        handleLabelHintHelpAlert(effectiveGroupId, "help", groupXFormsControl);
        handleLabelHintHelpAlert(effectiveGroupId, "alert", groupXFormsControl);
        handleLabelHintHelpAlert(effectiveGroupId, "hint", groupXFormsControl);

to XFormsGroupHandler.end(), and remove the existing label code from the start() method.

Label & hint work ok, although I haven't tested them in a repeat. Help seems to cause a javascript error when I hover over it, but at least the html is being generated now. Haven't actually tried alert.

Adrian

Adrian Baker wrote:

On a semi-related note, if there isn't already a bug tracker for it there's no handling for help/hint/alert in XFormsGroupHandler.

Is there a way to search across the bugs on the objectweb site? Without it it's pretty difficult to check that I'm not raising already-known issues.

Adrian

Adrian Baker wrote:
If I add a @xhtml:class to the label of a group it doesn't get translated into the generated html.

Looking at XFormsGroupHandler, it seems the call to getAttributes is mistakenly passing in the attributes of the xforms:group, not the xforms:label:
final AttributesImpl labelAttributes = getAttributes(attributes, "xforms-label", null);

This mean the generated html label doesn't get given the class in the @xhtml:class attribute on the xforms:label (but instead will incorrectly get any @xhtml:class declared on the enclosing group).

Looking at the revision history I'd say this was caused by the fix for #305144 (http://cvs.forge.objectweb.org/cgi-bin/viewcvs.cgi/ops/orbeon/src/java/org/orbeon/oxf/xforms/processor/handlers/XFormsGroupHandler.java.diff?r1=1.3&r2=1.4). But this must mean the OPS deployment on the orbeon site is pretty old, since it work's ok on there - so perhaps not?

Adrian

______________________________________________________________________
This email has been scanned by the MessageLabs Email Security System.
For more information please visit http://www.messagelabs.com/email ______________________________________________________________________
--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: [hidden email]
For general help: [hidden email]
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
  
______________________________________________________________________
This email has been scanned by the MessageLabs Email Security System.
For more information please visit http://www.messagelabs.com/email
______________________________________________________________________
--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: [hidden email]
For general help: [hidden email]
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
  

Erik Bruchez

Re: xforms:group/xforms:label/@xhtml:class ignored

Administrator

In reply to this post by Adrian Baker-2

Adrian Baker wrote:
> On a semi-related note, if there isn't already a bug tracker for it
> there's no handling for help/hint/alert in XFormsGroupHandler.
>
> Is there a way to search across the bugs on the objectweb site? Without
> it it's pretty difficult to check that I'm not raising already-known issues.

There is a search box on the Bugs page, above the tabs. Did you try that?

I don't think this is already tracked, so I created a new entry:

http://forge.objectweb.org/tracker/index.php?func=detail&aid=305897&group_id=168&atid=350207

-Erik

--
Orbeon - XForms Everywhere:
http://www.orbeon.com/blog/

--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws

Erik Bruchez

Re: xforms:group/xforms:label/@xhtml:class ignored

Administrator

In reply to this post by Adrian Baker-2

Adrian Baker wrote:

> Anyway, a fix for both these issues is to add
>
> handleLabelHintHelpAlert(effectiveGroupId, "label",
> groupXFormsControl);
> handleLabelHintHelpAlert(effectiveGroupId, "help",
> groupXFormsControl);
> handleLabelHintHelpAlert(effectiveGroupId, "alert",
> groupXFormsControl);
> handleLabelHintHelpAlert(effectiveGroupId, "hint",
> groupXFormsControl);
>
> to XFormsGroupHandler.end(), and remove the existing label code from the
> start() method.
>
> Label & hint work ok, although I haven't tested them in a repeat. Help
> seems to cause a javascript error when I hover over it, but at least the
> html is being generated now. Haven't actually tried alert.

It seems that this solution will cause the label to be output after all
the group's content, which is not good.

I think what we need to do is make attributes available from
XFormsControl instead of retrieving them from HandlerBase. Then we can
update handleLabelHintHelpAlert().

-Erik

--
Orbeon - XForms Everywhere:
http://www.orbeon.com/blog/

--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws

Adrian Baker-2

Re: xforms:group/xforms:label/@xhtml:class ignored

Erik Bruchez wrote:

> Adrian Baker wrote:
>> Anyway, a fix for both these issues is to add
>>
>> handleLabelHintHelpAlert(effectiveGroupId, "label",
>> groupXFormsControl);
>> handleLabelHintHelpAlert(effectiveGroupId, "help",
>> groupXFormsControl);
>> handleLabelHintHelpAlert(effectiveGroupId, "alert",
>> groupXFormsControl);
>> handleLabelHintHelpAlert(effectiveGroupId, "hint",
>> groupXFormsControl);
>>
>> to XFormsGroupHandler.end(), and remove the existing label code from
>> the start() method.
>>
>> Label & hint work ok, although I haven't tested them in a repeat.
>> Help seems to cause a javascript error when I hover over it, but at
>> least the html is being generated now. Haven't actually tried alert.
>
> It seems that this solution will cause the label to be output after
> all the group's content, which is not good.
>
> I think what we need to do is make attributes available from
> XFormsControl instead of retrieving them from HandlerBase. Then we can
> update handleLabelHintHelpAlert().
>
> -Erik

Of course yes, my bad. I was testing using an empty group (which I use
as a way to relocate the label of an actual control).

--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws

Erik Bruchez

Re: xforms:group/xforms:label/@xhtml:class ignored

Administrator

Adrian Baker wrote:

> Erik Bruchez wrote:
>> Adrian Baker wrote:
>>> Anyway, a fix for both these issues is to add
>>>
>>> handleLabelHintHelpAlert(effectiveGroupId, "label",
>>> groupXFormsControl);
>>> handleLabelHintHelpAlert(effectiveGroupId, "help",
>>> groupXFormsControl);
>>> handleLabelHintHelpAlert(effectiveGroupId, "alert",
>>> groupXFormsControl);
>>> handleLabelHintHelpAlert(effectiveGroupId, "hint",
>>> groupXFormsControl);
>>>
>>> to XFormsGroupHandler.end(), and remove the existing label code from
>>> the start() method.
>>>
>>> Label & hint work ok, although I haven't tested them in a repeat.
>>> Help seems to cause a javascript error when I hover over it, but at
>>> least the html is being generated now. Haven't actually tried alert.
>>
>> It seems that this solution will cause the label to be output after
>> all the group's content, which is not good.
>>
>> I think what we need to do is make attributes available from
>> XFormsControl instead of retrieving them from HandlerBase. Then we can
>> update handleLabelHintHelpAlert().
>>
>> -Erik
>
> Of course yes, my bad. I was testing using an empty group (which I use
> as a way to relocate the label of an actual control).

No problem ;-) Note that I have added support for help/hint/alert
though. This shouldn't cause any major issue, except maybe the question
of the placement of those items. For now I have placed them, like for
regular controls, after the end of the <span> containing the group.

-Erik

--
Orbeon - XForms Everywhere:
http://www.orbeon.com/blog/

--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws