Orbeon Forms community mailing list

radio button with value containing space not selected on startup

Classic

List

Threaded

2 messages Options

Adrian Baker-2

radio button with value containing space not selected on startup

OPS is mistakenly tokenising the value for a xforms:select1 with
appearance="full" in XFormsSelect1Handler:

private void handleItemFull(
...
// Case of multiple tokens
for (final StringTokenizer st = new StringTokenizer(controlValue);
st.hasMoreTokens();) {
final String token = st.nextToken();
if (token.equals(itemValue)) {
reusableAttributes.addAttribute("", "checked", "checked",
ContentHandlerHelper.CDATA, "checked");
break;
}
}

Looks like above code should be replaced with a call to the isSelected
method.

Attached is example demonstrating the problem - the radio button isn't
being displayed with the correct option.

Adrian

--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws

badRadioButton.xhtml (51K) Download Attachment

Erik Bruchez

Re: radio button with value containing space not selected on startup

Administrator

Adrian,

I think you are right, and the code of isSelected() should included the
special "" case as well.

I made this change and committed, but did not do heavy testing.

Note that the latest nightly builds have certain bugs related to repeat,
make sure to backup your current build before trying. Or, you may try
to just updated XFormsSelect1Handler.

-Erik

Adrian Baker wrote:

> OPS is mistakenly tokenising the value for a xforms:select1 with
> appearance="full" in XFormsSelect1Handler:
>
> private void handleItemFull( ...
> // Case of multiple tokens
> for (final StringTokenizer st = new StringTokenizer(controlValue);
> st.hasMoreTokens();) {
> final String token = st.nextToken();
> if (token.equals(itemValue)) {
> reusableAttributes.addAttribute("", "checked", "checked",
> ContentHandlerHelper.CDATA, "checked");
> break;
> }
> }
>
> Looks like above code should be replaced with a call to the isSelected
> method.
>
> Attached is example demonstrating the problem - the radio button isn't
> being displayed with the correct option.
>
> Adrian
>
>
>
>
> ------------------------------------------------------------------------
>
>
> --
> You receive this message as a subscriber of the [hidden email] mailing list.
> To unsubscribe: mailto:[hidden email]
> For general help: mailto:[hidden email]?subject=help
> ObjectWeb mailing lists service home page: http://www.objectweb.org/wws

--
Orbeon - XForms Everywhere:
http://www.orbeon.com/blog/

--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws