hiding the upload control while upload is in progress- bug

Adrian,

I was looking at this and I am a little confused. I do reproduce the issue, I think.

However, newDocument.xhtml is very large that it seems I am spending too much time trying to figure out what binds apply just to the issue of the upload. Is there any way you could produce a smaller reproducible example? This would help a bit.

Now the idea of the Java code you paste below is that we are trying to figure out whether we must tell the client to actually perform a background HTML form submission containing the files to upload.

If there are no bound upload controls, then it seems clear we do not need to ask the client to perform that submission. If the upload controls are not relevant, it seemed clear as well that those should not be taken into account.

So it seems that there may be an issue with this, but I am not sure exactly which issue since I can't quite figure out what your code tries to do ;-)

-Erik

Adrian Baker wrote:

We wanted to hide the file upload control while an upload occurs, to prevent any further file selections & make it clear that the upload is in progress.

We had a solution that seemed to worked ok: make the target node of the upload control non-relevant. However we noticed that uploads from the last upload control on a form were being ignored: the file would be sent to the server, but the instance data would not get updated. Attached is an example which shows the problem (use firefox so xforms-select events get fired to trigger the upload) - try uploading files for each of the three upload controls, and the final one will get ignored.

The problem is this check in XFormsModelSubmission:

    boolean hasBoundRelevantUploadControl = false;
    if (serialize) {
        final List uploadControls = xformsControls.getCurrentControlsState().getUploadControls();
        if (uploadControls != null) {
            for (Iterator i = uploadControls.iterator(); i.hasNext();) {
                final XFormsUploadControl currentControl = (XFormsUploadControl) i.next();
                if (currentControl.isRelevant()) {
                    final NodeInfo boundNodeInfo = currentControl.getBoundNode();
                    if (currentInstance ==  model.getInstanceForNode(boundNodeInfo)) {
                        // Found one relevant bound control
                        hasBoundRelevantUploadControl = true;
                        break;
                    }
                }
            }
        }
    }

This check remains true in the first two uploads, but when the final upload is triggered & the last upload control becomes irrelevant, and this check is no longer  true. The resulting submission is then treated incorrectly (isDeferredSubmission becomes false and so forth).

So ideally this optimisation would be modified somehow to still detect the submission.. On the other hand I'm not sure exactly what the correct spec behaviour when the relevance of the upload node is changed to false on xforms-select: maybe *all* the uploads should be being ignored? Either way the current behaviour is inconsistent though, either they should all be ignored, or none.

Adrian

badUploadForm.xhtml (53K) Download Attachment