configuring loading icon text, without resorting to theme xsl

Current the text of the "Loading..." message is hardcoded by this code in XHTMLBodyHandler:

    helper.text("Loading..."); // text is hardcoded, but you can rewrite it in the theme if needed

Unfortunately we've removed the theme stage because it gives a big (~25%) performance boost. Rather than relying on the theme stylesheet, I wonder if it would be better if the loading text could be set by a property, eg

    helper.text(OXFProperties.instance().getPropertySet().getString
            (XFormsConstants.XFORMS_AJAX_LOADING_ICON_TEXT, "loading"));

(In our case we actually set it to an empty string, leaving us just with a span to provide an image for).

Even better would be to make the property an XPath so you could address internationalisation issues more dynamically, but this would be a slightly bigger change.

Adrian



--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws

Adrian,

On 10/7/07, Adrian Baker <[hidden email]> wrote: Good point. I just talked to Erik about this, and we are planning to
implement this with an XInclude, which would be similar to what we did
for the error summary. I will add an RFE for this as soon as I can
access the Forge again, and post the URL to the bug here.

Alex
--
Orbeon Forms - Web 2.0 Forms, open-source, for the Enterprise
http://www.orbeon.com/


--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws

On 10/11/07, Alessandro Vernet <[hidden email]> wrote:
> Good point. I just talked to Erik about this, and we are planning to
> implement this with an XInclude, which would be similar to what we did
> for the error summary. I will add an RFE for this as soon as I can
> access the Forge again, and post the URL to the bug here.

Here is the RFE for tracking:

http://forge.objectweb.org/tracker/index.php?func=detail&aid=307700&group_id=168&atid=350207

Alex
--
Orbeon Forms - Web 2.0 Forms, open-source, for the Enterprise
http://www.orbeon.com/


--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws