bug: no xforms-submit-done event from replace="instance" submission with relevant upload

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

bug: no xforms-submit-done event from replace="instance" submission with relevant upload

Adrian Baker
I'm no longer getting xforms-submit-done events fired after a successful submission of an instance with an upload control bound to it.

The change which caused the problem seems to be revision 1.147 of XFormsModelSubmission:

    if (submitDone && !isDeferredSubmissionSecondPass) { // we don't want any changes to happen to the document upon xxforms-submit
        containingDocument.dispatchEvent(pipelineContext, new XFormsSubmitDoneEvent(XFormsModelSubmission.this));
    }

First pass at the test submitDone is false. Second pass submitDone is true, but
isDeferredSubmissionSecondPass is true.

Adrian



--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws
Reply | Threaded
Open this post in threaded view
|

Re: bug: no xforms-submit-done event from replace="instance" submission with relevant upload

Erik Bruchez
Administrator
Adrian,

Good catch. I entered and fixed this bug:

http://forge.objectweb.org/tracker/index.php?func=detail&aid=307674&group_id=168&atid=350207

This was changed to handle for two-pass submission with replace="all",
but it seems like this impacted the two-pass submission for
replace="instance|none" as well, which is wrong.

Please let us know if the changes I committed now fix your issue.

-Erik

Adrian Baker wrote:

> I'm no longer getting xforms-submit-done events fired after a successful
> submission of an instance with an upload control bound to it.
>
> The change which caused the problem seems to be revision 1.147 of
> XFormsModelSubmission:
>
>     if (submitDone && !isDeferredSubmissionSecondPass) { // we don't
> want any changes to happen to the document upon xxforms-submit
>         containingDocument.dispatchEvent(pipelineContext, new
> XFormsSubmitDoneEvent(XFormsModelSubmission.this));
>     }
>
> First pass at the test submitDone is false. Second pass submitDone is
> true, but isDeferredSubmissionSecondPass is true.
>
> Adrian
>

--
Orbeon Forms - Web Forms for the Enterprise Done the Right Way
http://www.orbeon.com/


--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws