Why to add the Bootstrap CCS by default in 4.6 ?

Hello,

I test orbeon 4.6, and I have many difference with the 4.4, on the display of radio button for example.

I think that is because Bootstrap CCS is now by default. (commit e0ee79f98ceaa2285e0c29ec990d4926e84cb0fc on XFormsFeatures.java)

I try to recompile XformsFeatures without this line :
new ResourceConfig("/apps/fr/style/bootstrap/css/bootstrap.css", "/apps/fr/style/bootstrap/css/bootstrap.min.css"),
new ResourceConfig("/apps/fr/style/form-runner-bootstrap-override.css", null),
           
And the result is like in orbeon 4.4.

It's possible to inactivate this feature ?

Thank You.

Julien

Hi Julien,

Not without changing the Java code, as you did. We "hardcoded" the dependency on Bootstrap because some of our base XForms JavaScript code now depends on it. For instance, the help functionality now uses Bootstrap popovers.

http://blog.orbeon.com/2014/01/improving-how-we-show-help-messages.html

We started using Bootstrap just in Form Builder / Form Runner, but some of those features made their way into the base XForms implementation. Also, in a way, Bootstrap (+jQuery) can be seen as a more modern replacement for lots of the feature of YUI, and from which we've been moving away for a while.

http://yahooeng.tumblr.com/post/96098168666/important-announcement-regarding-yui

I am not sure if this helps, but does it make sense? Do you see a more elegant way to handle this?

Alex

Hi Alessandro,

Ok, I understand why using Booststrap. It's a good library.
But I have to adjust my style sheet so that my application always has the same appearance in 4.6.

Specifically for radio buttons are now displayed one under the other, then I wish the display one next to the other : how I do that please ?

Thank You.

Julien.


-----Message d'origine-----
De : [hidden email] [mailto:[hidden email]] De la part de Alessandro Vernet
Envoyé : mardi 2 septembre 2014 00:37
À : [hidden email]
Objet : [Suspect Spam-Bulk] [orbeon] Re: Why to add the Bootstrap CCS by default in 4.6 ?

Hi Julien,

Not without changing the Java code, as you did. We "hardcoded" the dependency on Bootstrap because some of our base XForms JavaScript code now depends on it. For instance, the help functionality now uses Bootstrap popovers.

http://blog.orbeon.com/2014/01/improving-how-we-show-help-messages.html

We started using Bootstrap just in Form Builder / Form Runner, but some of those features made their way into the base XForms implementation. Also, in a way, Bootstrap (+jQuery) can be seen as a more modern replacement for lots of the feature of YUI, and from which we've been moving away for a while.

http://yahooeng.tumblr.com/post/96098168666/important-announcement-regarding-yui

I am not sure if this helps, but does it make sense? Do you see a more elegant way to handle this?

Alex

-----
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet
--
View this message in context: http://discuss.orbeon.com/Why-to-add-the-Bootstrap-CCS-by-default-in-4-6-tp4658754p4658757.html
Sent from the Orbeon Forms community mailing list mailing list archive at Nabble.com.

--
You received this message because you are subscribed to the Google Groups "Orbeon Forms" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].

--
You received this message because you are subscribed to the Google Groups "Orbeon Forms" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].

Hi Julien,

Good question. This would require the "inline" class to be added on every <label>, per the Bootstrap documentation. And unfortunately you cannot do this by changing some configuration. Also things haven't changed much in Bootstrap 3.x, where instead of adding an "inline "class, they have a "radio-inline" class. Bummer.

http://getbootstrap.com/2.3.2/base-css.html#forms
http://getbootstrap.com/css/#forms

If you need a solution to this in the short-term, you could change the code of the appropriate handler:

https://github.com/orbeon/orbeon-forms/blob/tag-release-4.6.2-ce/src/main/java/org/orbeon/oxf/xforms/processor/handlers/xhtml/XFormsSelect1Handler.java#L475

And for now, I created the flowing issue:

https://github.com/orbeon/orbeon-forms/issues/1889

Alex

Hi Alex,

Thank you very much for your response.
I had all the information I needed.

Julien

-----Message d'origine-----
De : [hidden email] [mailto:[hidden email]] De la part de Alessandro Vernet
Envoyé : mercredi 10 septembre 2014 00:34
À : [hidden email]
Objet : [orbeon] Re: Why to add the Bootstrap CCS by default in 4.6 ?

Hi Julien,

Good question. This would require the "inline" class to be added on every <label>, per the Bootstrap documentation. And unfortunately you cannot do this by changing some configuration. Also things haven't changed much in Bootstrap 3.x, where instead of adding an "inline "class, they have a "radio-inline" class. Bummer.

http://getbootstrap.com/2.3.2/base-css.html#forms
http://getbootstrap.com/css/#forms

If you need a solution to this in the short-term, you could change the code of the appropriate handler:

https://github.com/orbeon/orbeon-forms/blob/tag-release-4.6.2-ce/src/main/java/org/orbeon/oxf/xforms/processor/handlers/xhtml/XFormsSelect1Handler.java#L475

And for now, I created the flowing issue:

https://github.com/orbeon/orbeon-forms/issues/1889

Alex

-----
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet
--
View this message in context: http://discuss.orbeon.com/Why-to-add-the-Bootstrap-CCS-by-default-in-4-6-tp4658754p4658943.html
Sent from the Orbeon Forms community mailing list mailing list archive at Nabble.com.

--
You received this message because you are subscribed to the Google Groups "Orbeon Forms" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].

--
You received this message because you are subscribed to the Google Groups "Orbeon Forms" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].