Orbeon Forms community mailing list

Trouble compiling from CVS... why is that code here?

Classic

List

Threaded

10 messages Options

Rodney Gitzel

Trouble compiling from CVS... why is that code here?

Hi All,

I've got the latest code (I think) checked out of CVS, and am running into some strange problems compiling in Eclipse, even after reading http://www.orbeon.com/ops/doc/integration-development.

- org.orbeon.oxf.processor.IMProcessor is looking for ymsg.* packages, which don't seem to be in the distribution, so it should be removed from the workspace as well?

- struts-1.1.jar has gone missing from lib since TAG_OPS_3_6_0_200712061930 ? It's still needed to compile the current code in a quite a few places

Looking in build.xml it seems that these are specifically excluded from the build (looking at orbeon.jar confirms this), these along with the ones listed in the "integration-development" page. So I'm guessing these need to be added to that page.

<exclude name="org/orbeon/oxf/common/Version.java"/>
<exclude name="org/orbeon/oxf/resources/XMLDB*"/>
<exclude name="org/orbeon/oxf/processor/bpel/**/*.java"/>
<exclude name="org/orbeon/oxf/processor/IMProcessor*"/>
<exclude name="org/orbeon/oxf/processor/generator/Struts*.java"/>
<exclude name="org/orbeon/oxf/struts/**/*.java"/>
<exclude name="org/orbeon/oxf/util/Struts*.java"/>
<exclude name="org/orbeon/oxf/resources/Cache*"/>

But why are they still in the source code at all? Can they not be outright removed, or perhaps moved to an "extras" source tree? Why have it in the source tree if it has to be specifically ignored?

rodney

Erik Bruchez

Re: Trouble compiling from CVS... why is that code here?

Administrator

> I've got the latest code (I think) checked out of CVS, and am

> running into
> some strange problems compiling in Eclipse, even after reading
> http://www.orbeon.com/ops/doc/integration-development.
>
> - org.orbeon.oxf.processor.IMProcessor is looking for ymsg.*
> packages, which
> don't seem to be in the distribution, so it should be removed from the
> workspace as well?
>
> - struts-1.1.jar has gone missing from lib since
> TAG_OPS_3_6_0_200712061930
> ? It's still needed to compile the current code in a quite a few
> places
>
> Looking in build.xml it seems that these are specifically excluded
> from the
> build (looking at orbeon.jar confirms this), these along with the ones
> listed in the "integration-development" page. So I'm guessing
> these need
> to be added to that page.
>
> <exclude name="org/orbeon/oxf/common/Version.java"/>
> <exclude name="org/orbeon/oxf/resources/XMLDB*"/>
> <exclude name="org/orbeon/oxf/processor/bpel/**/*.java"/>
> <exclude name="org/orbeon/oxf/processor/IMProcessor*"/>
> <exclude
> name="org/orbeon/oxf/processor/generator/Struts*.java"/>
> <exclude name="org/orbeon/oxf/struts/**/*.java"/>
> <exclude name="org/orbeon/oxf/util/Struts*.java"/>
> <exclude name="org/orbeon/oxf/resources/Cache*"/>
>
>
> But why are they still in the source code at all? Can they not be
> outright
> removed, or perhaps moved to an "extras" source tree? Why have it
> in the
> source tree if it has to be specifically ignored?

I guess they could be removed, yes.

Doesn't Eclipse have ant integration, in which case it could just use
our ant targets to build?

-Erik

--
Orbeon Forms - Web Forms for the Enterprise Done the Right Way
http://www.orbeon.com/

--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws

Rodney Gitzel

Re: Trouble compiling from CVS... why is that code here?

Okay, if they can be removed, great, it would certainly do less to discourage people wanting to help with the project.

Of course I can run Ant scripts inside Eclipse, that's what I use to create the jar we currently test with. But if that's all I wanted then I could do it from the command-line and I wouldn't be using Eclipse.

rodney

Erik Bruchez wrote

I guess they could be removed, yes.

Doesn't Eclipse have ant integration, in which case it could just use
our ant targets to build?

-Erik

Erik Bruchez

Re: Re: Trouble compiling from CVS... why is that code here?

Administrator

Rodney,

I understand your point about making it easier to compile. In fact, we
already have an RFE for this:

http://tinyurl.com/5vd7bp

I just made that one clearer and bumped up the priority a bit.

However, from where I come from there are other reasons to use an IDE
than just compiling Java classes. I have been using IntelliJ IDEA for
years, and I always compile from the ant integration in that IDE.
Still, I couldn't live without an IDE for the editor, CVS support,
debugger, source code navigation, and especially refactoring. But
maybe that's just because IntelliJ's ant integration is better than
Eclipse's.

-Erik

On Jun 30, 2008, at 11:04 AM, Rodney Gitzel wrote:

>
> Okay, if they can be removed, great, it would certainly do less to
> discourage
> people wanting to help with the project.
>
> Of course I can run Ant scripts inside Eclipse, that's what I use to
> create
> the jar we currently test with. But if that's all I wanted then I
> could do
> it from the command-line and I wouldn't be using Eclipse.
>
> rodney
>
>
>
> Erik Bruchez wrote:
>>
>>
>> I guess they could be removed, yes.
>>
>> Doesn't Eclipse have ant integration, in which case it could just use
>> our ant targets to build?
>>
>> -Erik

--
Orbeon Forms - Web Forms for the Enterprise Done the Right Way
http://www.orbeon.com/

--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws

Rodney Gitzel

Re: Re: Trouble compiling from CVS... why is that code here?

Eclipse has this rather novel feature called "incremental compile" and so doesn't rely on Ant to do a build each time a file is touched.

If you like I can submit a patch to remove those packages.

rodney

Erik Bruchez wrote

Rodney,

I understand your point about making it easier to compile. In fact, we
already have an RFE for this:

http://tinyurl.com/5vd7bp

I just made that one clearer and bumped up the priority a bit.

However, from where I come from there are other reasons to use an IDE
than just compiling Java classes. I have been using IntelliJ IDEA for
years, and I always compile from the ant integration in that IDE.
Still, I couldn't live without an IDE for the editor, CVS support,
debugger, source code navigation, and especially refactoring. But
maybe that's just because IntelliJ's ant integration is better than
Eclipse's.

-Erik

On Jun 30, 2008, at 11:04 AM, Rodney Gitzel wrote:

>
> Okay, if they can be removed, great, it would certainly do less to
> discourage
> people wanting to help with the project.
>
> Of course I can run Ant scripts inside Eclipse, that's what I use to
> create
> the jar we currently test with. But if that's all I wanted then I
> could do
> it from the command-line and I wouldn't be using Eclipse.
>
> rodney
>
>
>
> Erik Bruchez wrote:
>>
>>
>> I guess they could be removed, yes.
>>
>> Doesn't Eclipse have ant integration, in which case it could just use
>> our ant targets to build?
>>
>> -Erik

--
Orbeon Forms - Web Forms for the Enterprise Done the Right Way
http://www.orbeon.com/

--
You receive this message as a subscriber of the ops-users@ow2.org mailing list.
To unsubscribe: mailto:ops-users-unsubscribe@ow2.org
For general help: mailto:sympa@ow2.org?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws

Alessandro Vernet

Re: Re: Re: Trouble compiling from CVS... why is that code here?

Administrator

Rodney,

On Fri, Jul 25, 2008 at 4:48 PM, Rodney Gitzel <[hidden email]> wrote:
>
> Eclipse has this rather novel feature called "incremental compile" and so
> doesn't rely on Ant to do a build each time a file is touched.

Is Eclipse using the build.xml to run the compilation, or is it
something completely independent? If the latter, then this is similar
to what I am doing with IntelliJ, i.e. just compiling the Java code
from IntelliJ when doing development, the benefits being that:

1. The compiler used by IntelliJ is better at detecting dependencies
between classes.
2. It is faster than running Ant.
3. When connected to the JVM, it will hot-swap the new classes that
have changed, so you don't need to restart Tomcat (or completely
reload the web application).

> If you like I can submit a patch to remove those packages.

Sure!

Alex
--
Orbeon Forms - Web 2.0 Forms, open-source, for the Enterprise
Orbeon's Blog: http://www.orbeon.com/blog/
Personal Blog: http://avernet.blogspot.com/
Twitter - http://twitter.com/avernet

--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws

Rodney Gitzel

Re: Re: Re: Trouble compiling from CVS... why is that code here?

Alex,

Sounds like pretty much the same idea. It's especially good for playing with an unfamiliar code-base, as any breakage caused by a given change is displayed almost immediately. So when there are classes that are known to not compile it becomes trickier to see what's failing for good reason and what's not.

Anyway, I did up a patch and went to put it in OW2, but I don't see anyplace to attach files. I have a text box for the comment and a submit button, but that's about it. Is there some trick to it?

Thanks.

rodney

Alessandro Vernet wrote

Is Eclipse using the build.xml to run the compilation, or is it
something completely independent? If the latter, then this is similar
to what I am doing with IntelliJ, i.e. just compiling the Java code
from IntelliJ when doing development, the benefits being that:

1. The compiler used by IntelliJ is better at detecting dependencies
between classes.
2. It is faster than running Ant.
3. When connected to the JVM, it will hot-swap the new classes that
have changed, so you don't need to restart Tomcat (or completely
reload the web application).

> If you like I can submit a patch to remove those packages.

Sure!

Alex

Alessandro Vernet

Re: Re: Re: Re: Trouble compiling from CVS... why is that code here?

Administrator

Rodney,

On Mon, Jul 28, 2008 at 2:27 PM, Rodney Gitzel <[hidden email]> wrote:
> Sounds like pretty much the same idea. It's especially good for playing
> with an unfamiliar code-base, as any breakage caused by a given change is
> displayed almost immediately. So when there are classes that are known to
> not compile it becomes trickier to see what's failing for good reason and
> what's not.

Exactly :).

> Anyway, I did up a patch and went to put it in OW2, but I don't see anyplace
> to attach files. I have a text box for the comment and a submit button, but
> that's about it. Is there some trick to it?

Are you referring to the tracker? There should be a file upload field
when you create a new entry. But honestly, unless this is really a big
file, you can just attach it to a message you post here in the mailing
list.

Alex
--
Orbeon Forms - Web 2.0 Forms, open-source, for the Enterprise
Orbeon's Blog: http://www.orbeon.com/blog/
Personal Blog: http://avernet.blogspot.com/
Twitter - http://twitter.com/avernet

--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws

Rodney Gitzel

Re: Re: Re: Re: Trouble compiling from CVS... why is that code here?

Okay, attached. I'll put a note in the bug tracker as to what the patch does.

Thanks!

rodney

remove_stuff.patch

Alessandro Vernet wrote

Are you referring to the tracker? There should be a file upload field
when you create a new entry. But honestly, unless this is really a big
file, you can just attach it to a message you post here in the mailing
list.

Alex

Erik Bruchez

Re: Re: Re: Re: Re: Trouble compiling from CVS... why is that code here?

Administrator

Hi Rodney,

Finally these changes are in. Please let us know if there is a problem.

Thanks,

-Erik

On Jul 29, 2008, at 9:53 AM, Rodney Gitzel wrote:

>
> Okay, attached. I'll put a note in the bug tracker as to what the
> patch
> does.
>
> Thanks!
>
> rodney
>
> http://www.nabble.com/file/p18716634/remove_stuff.patch
> remove_stuff.patch
>
>
>
> Alessandro Vernet wrote:
>>
>>
>> Are you referring to the tracker? There should be a file upload field
>> when you create a new entry. But honestly, unless this is really a
>> big
>> file, you can just attach it to a message you post here in the
>> mailing
>> list.
>>
>> Alex