Orbeon Forms community mailing list

Swedish localization -- contribution offered

Classic

List

Threaded

9 messages Options

sodastream

Swedish localization -- contribution offered

Hi,

My previous fiddling with language selection (useless thread here) veered into this class, among other things:
org.orbeon.saxon.number.Numberer_sv
part of localization for the Swedish language.

The class was surprisingly close to real Swedish, considering the non-Swedish author seems to have created the code using Wikipedia articles. However, for a native Swede there were a handful of disturbing inaccuracies which I corrected.

The source seems to be part of Saxon rather than Orbeon, but I got the impression that Erik Bruchez is a committer there. I'm ready to ship the code (with a substantial amount of unit tests) any time. How do we get about it?

/Hakan

P.S. A Swedish localization for the Form Runner is well underway but needs some polishing.

Alessandro Vernet

Re: Swedish localization -- contribution offered

Administrator

Hi Hakan,

Feel free to send us the updated Numberer_sv.java as an attachment in this thread, and we'll integrate it into the code. (In the same way, we recently added a Numberer_es.java for Spanish, for which, surprisingly, there was no support at all!)

Alex

--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet

sodastream

Re: Swedish localization -- contribution offered

Great, here we go. I uploaded a complete kit with unit tests. If you want,
-- Compile the stuff with numcompile.sh (assumes Java, I used Java 6)
-- Run the test with numtest.sh (assumes Groovy, I used Groovy 1.8)

In any case, the source (just a single file) is at the bottom of the org/ hierarchy:
/org/orbeon/saxon/number/Numberer_sv.java
This is the file to replace in Saxon.

Thanks,
Hakan

The kit is uploaded here: numberer-sv-130416.tgz

Erik Bruchez

Re: Swedish localization -- contribution offered

Administrator

Hakan,

Excellent, I committed this and updated your tests to Scala with a bit
of query/replace:

https://github.com/orbeon/orbeon-forms/commit/8ecec12c972784e155d8304e62f384957750486e

I noticed that testDateRelated() failed with the trailing spaces in
strings, so removed those. I suppose that's fine?

Also, could you please either:

1. Send us a signed CLA:

http://wiki.orbeon.com/forms/community/cla

2. Or alternatively, confirm that we can place both files under the
MPL license used by Saxon?

We do need source code licensing to be 100% clear.

Thanks,

-Erik

On Tue, Apr 16, 2013 at 1:41 AM, sodastream
<[hidden email]> wrote:

> Great, here we go. I uploaded a complete kit with unit tests. If you want,
> -- Compile the stuff with numcompile.sh (assumes Java, I used Java 6)
> -- Run the test with numtest.sh (assumes Groovy, I used Groovy 1.8)
>
> In any case, the source (just a single file) is at the bottom of the org/
> hierarchy:
> /org/orbeon/saxon/number/Numberer_sv.java
> This is the file to replace in Saxon.
>
> Thanks,
> Hakan
>
> The kit is uploaded here: numberer-sv-130416.tgz
> <http://discuss.orbeon.com/file/n4656550/numberer-sv-130416.tgz>
>
> --
> View this message in context: http://discuss.orbeon.com/Swedish-localization-contribution-offered-tp4656518p4656550.html
> Sent from the Orbeon Forms community mailing list mailing list archive at Nabble.com.
>
> --
> You received this message because you are subscribed to the Google Groups "Orbeon Forms" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
> To post to this group, send email to [hidden email].
>
>

--
You received this message because you are subscribed to the Google Groups "Orbeon Forms" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].

sodastream

Re: Swedish localization -- contribution offered

Great, Erik. The formalities may take a week, but we will produce a statement according to your guidelines, of course.

Uh, I'm a little disturbed by those failing tests. I don't quite get that bit about "trailing spaces in strings", could you clarify? I'm worried that you may have found a bug!

/Hakan

Erik Bruchez

Re: Swedish localization -- contribution offered

Administrator

Don't worry, comparing the files again it seems that this must have been a result of my conversion with regexps, which incorrectly added a trailing space in strings such as 'jan'. So all should be good!

-Erik

Erik Bruchez

Re: Swedish localization -- contribution offered

Administrator

Hakan,

Any progress on the CLA or MPL front? Please note we'll have to pull
the commit from github if we don't get an update rapidly :-(

Thanks!

-Erik

On Thu, Apr 18, 2013 at 9:57 AM, Erik Bruchez <[hidden email]> wrote:

> Don't worry, comparing the files again it seems that this must have been a
> result of my conversion with regexps, which incorrectly added a trailing
> space in strings such as 'jan'. So all should be good!
>
> -Erik
>
> --
> View this message in context: http://discuss.orbeon.com/Swedish-localization-contribution-offered-tp4656518p4656595.html
> Sent from the Orbeon Forms community mailing list mailing list archive at Nabble.com.
>
> --
> You received this message because you are subscribed to the Google Groups "Orbeon Forms" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
> To post to this group, send email to [hidden email].
>
>

sodastream

Re: Swedish localization -- contribution offered

Eric, goodness, sorry to have lost grip on this matter.

I hereby confirm that you may place both files under the MPL license used by Saxon. Completely in line with our intention.

Thanks,
Hakan

Erik Bruchez

Re: Swedish localization -- contribution offered

Administrator

Hakan,

Excellent, thanks for confirming! And sorry for pushing on this but I
didn't want this to linger!

Regards,

-Erik

On Tue, May 7, 2013 at 10:37 AM, sodastream
<[hidden email]> wrote:

> Eric, goodness, sorry to have lost grip on this matter.
>
> I hereby confirm that you may place both files under the MPL license used by
> Saxon. Completely in line with our intention.
>
> Thanks,
> Hakan
>
> --
> View this message in context: http://discuss.orbeon.com/Swedish-localization-contribution-offered-tp4656518p4656720.html
> Sent from the Orbeon Forms community mailing list mailing list archive at Nabble.com.
>
> --
> You received this message because you are subscribed to the Google Groups "Orbeon Forms" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
> To post to this group, send email to [hidden email].
>
>