Re: patch: support error-type attribute on xforms-submit-error event

> Adrian,
>
> Fantastic, we will try to integrate this ASAP.
>
> -Erik
>
> Adrian Baker wrote:
>> Fixed version attached.
>>
>> Adrian Baker
>> wrote:file:///E:/dev/Orbeon/Orion/work/src/java/org/orbeon/oxf/xforms/event/events/XFormsSubmitErrorEvent.java
>> <imap://[hidden email]:143/fetch%3EUID%3E.INBOX.Orbeon.ops-users%3E15230?header=quotebody&part=1.1.2&filename=XFormsSubmitErrorEvent.java>
>>
>>> Oops - slight problem with passing the connection result around: it's
>>> stream gets closed before it's read in the XFormsSubmitErrorEvent
>>> constructor. Will fix and resend.
>>>
>>> Adrian Baker wrote:
>>>> Attached is a fairly straightforward patch to XFormsModelSubmission
>>>> et al to support the XForms 1.1 error-type attribute
>>>> (http://www.w3.org/TR/xforms11/#submit-evt-submit).
>>>>
>>>> This event is particularly useful for distinguishing between
>>>> submission failures caused by invalid data (user error) or a failure
>>>> of the submission target (system error). Previously I had been using
>>>> the xforms-submit-serialize to set a flag to identify the two cases,
>>>> but came across a case where this was broken by @serialize="false" on
>>>> the <xf:submission>, and rather than update my rather fiddly
>>>> workaround it was quicker to implement the proper solution.
>>>>
>>>> Previously the XFormsSubmitError event was being created throughout
>>>> the body of the performDefaultAction() method (always just before an
>>>> exception is thrown), as well as in a catch block in the bottom. I
>>>> felt a bit uneasy about spreading the creation around like this, and
>>>> changed this so the event is created solely in the catch block at the
>>>> bottom, since there is always an exception thrown if the submission
>>>> fails.
>>>>
>>>> Adrian
>>>>
>>>> ______________________________________________________________________
>>>> This email has been scanned by the MessageLabs Email Security System.
>>>> For more information please visit http://www.messagelabs.com/email
>>>> ______________________________________________________________________
>>> ______________________________________________________________________
>>> This email has been scanned by the MessageLabs Email Security System.
>>> For more information please visit http://www.messagelabs.com/email
>>> ______________________________________________________________________
>
>

> What's the status of this? Is there a tracker item?
>
> Erik Bruchez <[hidden email]> wrote:
>> Adrian,
>> Fantastic, we will try to integrate this ASAP.
>> -Erik
>> Adrian Baker wrote:
>>> Fixed version attached.
>>>
>>> Adrian Baker wrote:file:///E:/dev/Orbeon/Orion/work/src/java/org/orbeon/oxf/xforms/event/events/XFormsSubmitErrorEvent.java
>>>  <imap://[hidden email]:143/fetch%3EUID%3E.INBOX.Orbeon.ops-users%3E15230?header=quotebody&part=1.1.2&filename=XFormsSubmitErrorEvent.java
>>> >
>>>> Oops - slight problem with passing the connection result around:  
>>>> it's stream gets closed before it's read in the  
>>>> XFormsSubmitErrorEvent constructor. Will fix and resend.
>>>>
>>>> Adrian Baker wrote:
>>>>> Attached is a fairly straightforward patch to  
>>>>> XFormsModelSubmission et al to support the XForms 1.1 error-type  
>>>>> attribute (http://www.w3.org/TR/xforms11/#submit-evt-submit).
>>>>>
>>>>> This event is particularly useful for distinguishing between  
>>>>> submission failures caused by invalid data (user error) or a  
>>>>> failure of the submission target (system error). Previously I  
>>>>> had been using the xforms-submit-serialize to set a flag to  
>>>>> identify the two cases, but came across a case where this was  
>>>>> broken by @serialize="false" on the <xf:submission>, and rather  
>>>>> than update my rather fiddly workaround it was quicker to  
>>>>> implement the proper solution.
>>>>>
>>>>> Previously the XFormsSubmitError event was being created  
>>>>> throughout the body of the performDefaultAction() method (always  
>>>>> just before an exception is thrown), as well as in a catch block  
>>>>> in the bottom. I felt a bit uneasy about spreading the creation  
>>>>> around like this, and changed this so the event is created  
>>>>> solely in the catch block at the bottom, since there is always  
>>>>> an exception thrown if the submission fails.
>>>>>
>>>>> Adrian
>>>>>
>>>>> ______________________________________________________________________
>>>>> This email has been scanned by the MessageLabs Email Security  
>>>>> System.
>>>>> For more information please visit http://www.messagelabs.com/email
>>>>> ______________________________________________________________________
>>>> ______________________________________________________________________
>>>> This email has been scanned by the MessageLabs Email Security  
>>>> System.
>>>> For more information please visit http://www.messagelabs.com/email
>>>> ______________________________________________________________________
>
>
> --
> You receive this message as a subscriber of the [hidden email]  
> mailing list.
> To unsubscribe: mailto:[hidden email]
> For general help: mailto:[hidden email]?subject=help
> OW2 mailing lists service home page: http://www.ow2.org/wws