Persistence Layer - Custom Error Message

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

Persistence Layer - Custom Error Message

bruno.buzzi
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: Persistence Layer - Custom Error Message

bruno.buzzi
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: Persistence Layer - Custom Error Message

Alessandro  Vernet
Administrator
Hi Bruno,

Publishing ends up running publish() in PublishOps:

https://github.com/orbeon/orbeon-forms/blob/master/src/main/scala/org/orbeon/oxf/fb/PublishOps.scala

But as you can see from the code, currently, when an error happens, it just toggles fb-publish-dialog-error, but it doesn't extract any information from the exception, so right now you can't really show any detail about the error.

We've found that showing end users details about errors coming from the backend is at best not very useful, and at worse could cause security problems. In your case, just telling users that an error happened isn't enough?

Alex
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet
Reply | Threaded
Open this post in threaded view
|

Re: Persistence Layer - Custom Error Message

bruno.buzzi
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: Persistence Layer - Custom Error Message

Alessandro  Vernet
Administrator
Hi Bruno, got it, and indeed it sounds better to catch possible inconsistencies as early as possible.

Alex
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet
Reply | Threaded
Open this post in threaded view
|

Re: Persistence Layer - Custom Error Message

bruno.buzzi
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: Persistence Layer - Custom Error Message

bruno.buzzi
This post was updated on .
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: Persistence Layer - Custom Error Message

Alessandro  Vernet
Administrator
Hi Bruno,

The way summary pages handle different form versions is… non-existent, which is a problem. Right now the summary page uses the latest version of the form definition, and behaves as if all the data was for that version (which, obviously isn't necessarily the case). Improving this situation is covered by:

https://github.com/orbeon/orbeon-forms/issues/1435

You're suggesting to have a dropdown to select the version on the summary page. This is also what we've been thinking.

About detecting incompatible changes, that would be done at publish time, correct? I.e. Form Builder could do that detection, and appropriately suggest to create a new version or overwrite the existing version. Is this also what you have in mind?

Alex
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet
Reply | Threaded
Open this post in threaded view
|

Re: Persistence Layer - Custom Error Message

bruno.buzzi
CONTENTS DELETED
The author has deleted this message.
Reply | Threaded
Open this post in threaded view
|

Re: Persistence Layer - Custom Error Message

Alessandro  Vernet
Administrator
Hi Bruno,

About finding the differences between forms, we're just working on this now, and if everything goes well, it should be done in a few weeks. So at that point, we can share a build with you so you can see if this is also inline with what you are looking for.

Alex
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet
Reply | Threaded
Open this post in threaded view
|

Re: Persistence Layer - Custom Error Message

Alessandro  Vernet
Administrator
Hi Bruno,

Just a quick update on this one: some other things came up, and this won't be in 2016.2, but most likely will be in the following release. At this point, we're planning to implement this before the end of the summer.

Alex
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet