Minor bug in Form Builder

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Minor bug in Form Builder

Alexey Vasyukov
Hi folks.

It's me again. I'm sorry for spaming the list, but I try to adhere to "one topic - one mail" approach.

I found a minor bug in Form Builder. Steps to reproduce:

1. Limit the list of available applications with form-runner-roles.xml
<role name="*" app="test" form="*"/>
<role name="*" app="test2" form="*"/>

2. Ask Form Builder to create a new form. The dialog pops up telling "Edit the application name and form name, or click Cancel to return to the builder". (From this label I guess it is technically the same dialog that is used for editing metadata of existing form.)

3. Enter nothing in the dialog. Press Cancel. Form Builder with the new form will be opened (as far as I understand, you are "returned to the builder"). Look at the metadata - "app" field is set to "test" (the first app from available ones according to form-runner-roles.xml) and "form" field is left blank.

4. Edit the form as usual.

5. Click Save. The form is saved successfully.

6. Click Publish. The dialog pops up telling "There was an error during form publishing". It is pretty tricky now to understand what is the problem unless it was the result of intentional experiment. :-)


As far as I understand, possible simple fix for it is to use always default "restrictive" dialog during new form creation - in this case Cancel button directs you to summary page, not new form edit page. Unfortunatelly I do not understand Form Builder internals good enough to propose a patch, so, may be I am wrong.


I hope this report can be usefull.


Best regards,
Alexey


--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws
Reply | Threaded
Open this post in threaded view
|

Re: Minor bug in Form Builder

Erik Bruchez
Administrator
Alexey,

No spam at all.

Thanks for reporting this. I reproduced it and fixed it:

https://github.com/orbeon/orbeon-forms/commit/f4f964c9b5c65dec09e4dead2ac9c6879e151c91

Please let us know if this works for you.

-Erik

On Sun, Dec 5, 2010 at 12:20 PM, Alexey Vasyukov <[hidden email]> wrote:

> Hi folks.
> It's me again. I'm sorry for spaming the list, but I try to adhere to "one
> topic - one mail" approach.
> I found a minor bug in Form Builder. Steps to reproduce:
> 1. Limit the list of available applications with form-runner-roles.xml
> <role name="*" app="test" form="*"/>
> <role name="*" app="test2" form="*"/>
> 2. Ask Form Builder to create a new form. The dialog pops up telling "Edit
> the application name and form name, or click Cancel to return to the
> builder". (From this label I guess it is technically the same dialog that is
> used for editing metadata of existing form.)
> 3. Enter nothing in the dialog. Press Cancel. Form Builder with the new form
> will be opened (as far as I understand, you are "returned to the builder").
> Look at the metadata - "app" field is set to "test" (the first app from
> available ones according to form-runner-roles.xml) and "form" field is left
> blank.
> 4. Edit the form as usual.
> 5. Click Save. The form is saved successfully.
> 6. Click Publish. The dialog pops up telling "There was an error during form
> publishing". It is pretty tricky now to understand what is the problem
> unless it was the result of intentional experiment. :-)
>
> As far as I understand, possible simple fix for it is to use always default
> "restrictive" dialog during new form creation - in this case Cancel button
> directs you to summary page, not new form edit page. Unfortunatelly I do not
> understand Form Builder internals good enough to propose a patch, so, may be
> I am wrong.
>
> I hope this report can be usefull.
>
> Best regards,
> Alexey
>
> --
> You receive this message as a subscriber of the [hidden email] mailing
> list.
> To unsubscribe: mailto:[hidden email]
> For general help: mailto:[hidden email]?subject=help
> OW2 mailing lists service home page: http://www.ow2.org/wws
>
>


--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws
Reply | Threaded
Open this post in threaded view
|

Re: Re: Minor bug in Form Builder

Alexey Vasyukov
Hello Erik,

Just tested git version. Yes, it works for me, everything is fixed. Many thanks for prompt reaction!


Alexey


2010/12/7 Erik Bruchez <[hidden email]>
Alexey,

No spam at all.

Thanks for reporting this. I reproduced it and fixed it:

https://github.com/orbeon/orbeon-forms/commit/f4f964c9b5c65dec09e4dead2ac9c6879e151c91

Please let us know if this works for you.

-Erik

On Sun, Dec 5, 2010 at 12:20 PM, Alexey Vasyukov <[hidden email]> wrote:
> Hi folks.
> It's me again. I'm sorry for spaming the list, but I try to adhere to "one
> topic - one mail" approach.
> I found a minor bug in Form Builder. Steps to reproduce:
> 1. Limit the list of available applications with form-runner-roles.xml
> <role name="*" app="test" form="*"/>
> <role name="*" app="test2" form="*"/>
> 2. Ask Form Builder to create a new form. The dialog pops up telling "Edit
> the application name and form name, or click Cancel to return to the
> builder". (From this label I guess it is technically the same dialog that is
> used for editing metadata of existing form.)
> 3. Enter nothing in the dialog. Press Cancel. Form Builder with the new form
> will be opened (as far as I understand, you are "returned to the builder").
> Look at the metadata - "app" field is set to "test" (the first app from
> available ones according to form-runner-roles.xml) and "form" field is left
> blank.
> 4. Edit the form as usual.
> 5. Click Save. The form is saved successfully.
> 6. Click Publish. The dialog pops up telling "There was an error during form
> publishing". It is pretty tricky now to understand what is the problem
> unless it was the result of intentional experiment. :-)
>
> As far as I understand, possible simple fix for it is to use always default
> "restrictive" dialog during new form creation - in this case Cancel button
> directs you to summary page, not new form edit page. Unfortunatelly I do not
> understand Form Builder internals good enough to propose a patch, so, may be
> I am wrong.
>
> I hope this report can be usefull.
>
> Best regards,
> Alexey
>
> --
> You receive this message as a subscriber of the [hidden email] mailing
> list.
> To unsubscribe: mailto:[hidden email]
> For general help: mailto:[hidden email]?subject=help
> OW2 mailing lists service home page: http://www.ow2.org/wws
>
>


--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws




--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws