Orbeon Forms community mailing list

Minimal Test of Issue #235

Classic

List

Threaded

3 messages Options

Aaron Spike

Minimal Test of Issue #235

I've been investigating the disappearance of comments in the exist persistence layer:

https://github.com/orbeon/orbeon-forms/issues/235

You said that it was most likely that they were getting lost inside of crud.xpl:

https://twitter.com/orbeon/status/525689223190306817

I wanted to see if I could reproduce the same behavior in my own minimal app. And I think my testing indicates that the comments could in fact be stripped prior to arriving at crud.xpl.

Please see the attached app.

Aaron Spike

This electronic communication, including any attached documents, may contain confidential and/or legally privileged information that is intended only for use by the recipient(s) named above. If you have received this communication in error, please notify the sender immediately and delete the communication and any attachments. Views expressed by the author do not necessarily represent those of Martin Luther College.

--
You received this message because you are subscribed to the Google Groups "Orbeon Forms" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].

issue_235.tar.gz (2K) Download Attachment

Aaron Spike

Re: Minimal Test of Issue #235

I just stumbled upon this comment in the source:

https://github.com/orbeon/orbeon-forms/blob/master/src/main/java/org/orbeon/oxf/processor/generator/URLGenerator.java#L972

Might this be where xml comments stop propagating?

Erik Bruchez

Re: Minimal Test of Issue #235

Administrator

For reference, Aaron's fix:

https://github.com/martinluther/orbeon-forms/commit/180ce12c8ce0847a0c5938c537d142fecf5cabdf

-Erik