LDAPProcessor update

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

LDAPProcessor update

Hřib Zdeněk
Hello,

I have added some new features LDAPProcessor class. I tried to send the github pull request to merge my changes back to official trunk, but I have no response. I am not sure if I should notify someone as well or if it means that my code is so bad :-( .
https://github.com/orbeon/orbeon-forms/pull/4 ([hidden email])

Zdenek Hrib



--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws
Reply | Threaded
Open this post in threaded view
|

Re: LDAPProcessor update

Erik Bruchez
Administrator
Zdenek,

Sorry about that: I saw the pull request. We do plan to integrate the changes!

-Erik

2011/8/3 Hřib Zdeněk <[hidden email]>:

> Hello,
>
> I have added some new features LDAPProcessor class. I tried to send the github pull request to merge my changes back to official trunk, but I have no response. I am not sure if I should notify someone as well or if it means that my code is so bad :-( .
> https://github.com/orbeon/orbeon-forms/pull/4 ([hidden email])
>
> Zdenek Hrib
>
>
>
> --
> You receive this message as a subscriber of the [hidden email] mailing list.
> To unsubscribe: mailto:[hidden email]
> For general help: mailto:[hidden email]?subject=help
> OW2 mailing lists service home page: http://www.ow2.org/wws
>
>


--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws
Reply | Threaded
Open this post in threaded view
|

RE: Re: LDAPProcessor update

Hřib Zdeněk
Hello,

OK. Great! I just found that the update I made does not work as expected with the former configuration (default scope changed from SUBTREE to ONELEVEL). I have made the update but unfortunatelly I commited also some irrelevant modifications to SessionInvalidator.java. I am a git newbie so please just ignore the modifications to SessionInvalidator.java in the pull request.

Thank you

Zdenek Hrib

-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On Behalf Of Erik Bruchez
Sent: Tuesday, August 09, 2011 7:08 AM
To: [hidden email]
Subject: [ops-users] Re: LDAPProcessor update

Zdenek,

Sorry about that: I saw the pull request. We do plan to integrate the changes!

-Erik

2011/8/3 Hřib Zdeněk <[hidden email]>:

> Hello,
>
> I have added some new features LDAPProcessor class. I tried to send the github pull request to merge my changes back to official trunk, but I have no response. I am not sure if I should notify someone as well or if it means that my code is so bad :-( .
> https://github.com/orbeon/orbeon-forms/pull/4 ([hidden email])
>
> Zdenek Hrib
>
>
>
> --
> You receive this message as a subscriber of the [hidden email] mailing list.
> To unsubscribe: mailto:[hidden email]
> For general help: mailto:[hidden email]?subject=help
> OW2 mailing lists service home page: http://www.ow2.org/wws
>
>


--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws
Reply | Threaded
Open this post in threaded view
|

Re: RE: Re: LDAPProcessor update

Erik Bruchez
Administrator
Ok got it!

-Erik

On Wed, Aug 10, 2011 at 3:20 AM, Hřib Zdeněk <[hidden email]> wrote:

> Hello,
>
> OK. Great! I just found that the update I made does not work as expected with the former configuration (default scope changed from SUBTREE to ONELEVEL). I have made the update but unfortunatelly I commited also some irrelevant modifications to SessionInvalidator.java. I am a git newbie so please just ignore the modifications to SessionInvalidator.java in the pull request.
>
> Thank you
>
> Zdenek Hrib
>
> -----Original Message-----
> From: [hidden email] [mailto:[hidden email]] On Behalf Of Erik Bruchez
> Sent: Tuesday, August 09, 2011 7:08 AM
> To: [hidden email]
> Subject: [ops-users] Re: LDAPProcessor update
>
> Zdenek,
>
> Sorry about that: I saw the pull request. We do plan to integrate the changes!
>
> -Erik
>
> 2011/8/3 Hřib Zdeněk <[hidden email]>:
>> Hello,
>>
>> I have added some new features LDAPProcessor class. I tried to send the github pull request to merge my changes back to official trunk, but I have no response. I am not sure if I should notify someone as well or if it means that my code is so bad :-( .
>> https://github.com/orbeon/orbeon-forms/pull/4 ([hidden email])
>>
>> Zdenek Hrib
>>
>>
>>
>> --
>> You receive this message as a subscriber of the [hidden email] mailing list.
>> To unsubscribe: mailto:[hidden email]
>> For general help: mailto:[hidden email]?subject=help
>> OW2 mailing lists service home page: http://www.ow2.org/wws
>>
>>
>
>
> --
> You receive this message as a subscriber of the [hidden email] mailing list.
> To unsubscribe: mailto:[hidden email]
> For general help: mailto:[hidden email]?subject=help
> OW2 mailing lists service home page: http://www.ow2.org/wws
>
>


--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws