Group label does not pick up MIP classes on initialisation

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Group label does not pick up MIP classes on initialisation

David McIntyre
We've hit a snag with the recent changes to the handling of group labels.
 
As things currently stand, the group label is always rendered with a class of "xforms-label" regardless of any MIPs that the group might have.
 
An effect of this is that, if the group is non-relevant initially, its label still shows even though the contents of the group do not.
 
Subsequent changes to the relevance of the group correctly show and hide the label along with the group.  See the attached file for a sandbox example.
 
The cause is the line
 
             reusableAttributes.addAttribute("", "class", "class", ContentHandlerHelper.CDATA, "xforms-label"));
in XFormsGroupHandler.java, which doesn't incorporate either MIPs or existing classes on the label element.
 
Cheers,
 
    Dave Mc
 
 
 
Dave McIntyre   MA, DPhil, GradDipSci
Software Developer
[hidden email]
P: +64 9 638 0600
F: +64 9 638 0699
M: +64 21 212 8087
S: dave.mcintyre


--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws

relevant-group-labels.xhtml (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Group label does not pick up MIP classes on initialisation

Erik Bruchez
Administrator
David,

Thanks for the bug-report! I entered and fixed this bug:

http://forge.objectweb.org/tracker/index.php?func=detail&aid=307403&group_id=168&atid=350207

-Erik

David McIntyre wrote:

> We've hit a snag with the recent changes to the handling of group labels.
>  
> As things currently stand, the group label is always rendered with a
> class of "xforms-label" regardless of any MIPs that the group might have.
>  
> An effect of this is that, if the group is non-relevant initially, its
> label still shows even though the contents of the group do not.
>  
> Subsequent changes to the relevance of the group correctly show and hide
> the label along with the group.  See the attached file for a sandbox
> example.
>  
> The cause is the line
>  
>              reusableAttributes.addAttribute("", "class", "class",
> ContentHandlerHelper.CDATA, "xforms-label"));
> in XFormsGroupHandler.java, which doesn't incorporate either MIPs or
> existing classes on the label element.
>  
> Cheers,
>  
>     Dave Mc
>  
>  
>  
>
> **
>
> *Dave McIntyre   *MA, DPhil, GradDipSci
> *Software Developer*
> [hidden email] <mailto:[hidden email]>
> P: +64 9 638 0600
> F: +64 9 638 0699
> M: +64 21 212 8087
> S: dave.mcintyre
> www.orionhealth.com <http://www.orionhealth.com/>
>

--
Orbeon Forms - Web Forms for the Enterprise Done the Right Way
http://www.orbeon.com/



--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
ObjectWeb mailing lists service home page: http://www.objectweb.org/wws