Orbeon Forms community mailing list

Delete of Upload in Repeat causes incorrect UI update on the client.

Classic

List

Threaded

6 messages Options

Nick Van den Bleeken

Delete of Upload in Repeat causes incorrect UI update on the client.

Hi,

The UI on the client is incorrectly updated when you delete an upload control from a repeat.

To reproduce this:

1. open the ‘xforms-upload’ sample app (http://localhost:8080/orbeon/xforms-upload/ or http://www.orbeon.com/ops/xforms-upload/ )

2. select 3 different files

3. hit the delete button on the second row

4. You will now see that the last (third) row seems to be deleted,

On the server the second row is deleted, I tested this with a simple app that added an id to each row and added it as an XForms output, this output was also correctly updated on the client.

Maybe this problem is related to [1], but I really need to fix this. I even want to fix this myself, but I’m new to Orbeon, and don’t know how to debug the client side code with firebug, I only see three js files in firebug and not the ones containing the Orbeon code. Is there any documentation about how to set this up? (I can easily debug the server side code in my IDE, but the client side code is the problem)

Regards,

Nick Van den Bleeken - Research & Development Manager
Inventive Designers
Phone: +32 - 3 - 8210170
Fax: +32 - 3 - 8210171
Email: [hidden email]

1: http://forge.objectweb.org/tracker/index.php?func=detail&aid=305539&group_id=168&atid=350207

Inventive Designers' Email Disclaimer:
http://www.inventivedesigners.com/email-disclaimer

--
This message has been scanned for viruses and
dangerous content, and is believed to be clean.
--

--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws

Alessandro Vernet

Re: Delete of Upload in Repeat causes incorrect UI update on the client.

Administrator

Nick,

Nick_Van_den_Bleeken-2 wrote

The UI on the client is incorrectly updated when you delete an upload control from a repeat.

To reproduce this:

1. open the 'xforms-upload' sample app (http://localhost:8080/orbeon/xforms-upload/ or http://www.orbeon.com/ops/xforms-upload/ )

2. select 3 different files

3. hit the delete button on the second row

4. You will now see that the last (third) row seems to be deleted,

I was unable to reproduce this. I selected 3 files (1.html, 2.html, and 3.html) and after I press on the delete button in the second row I see that only the 1st and 3rd files are left. Have you managed to reproduce this with nightly builds?

Alex

Nick Van den Bleeken

RE: Re: Delete of Upload in Repeat causes incorrect UI update on the client.

Hi Alex,

Think you for the fast reply, I think I know what you are doing different then me. Can it be that you hit the Upload selected files before doing the delete of the second entry? It looks like this when I see your screen shot, and if I do this I can't reproduce the problem either.

To reproduce the problem just select the three files, and then hit the delete button on the second row (without first hitting the Upload selected Files button)

Regards,

Nick Van den Bleeken - Research & Development Manager
Inventive Designers
Phone: +32 - 3 - 8210170
Fax: +32 - 3 - 8210171
Email: [hidden email]

> -----Original Message-----
> From: Alessandro Vernet [mailto:[hidden email]]
> Sent: maandag 16 maart 2009 23:10
> To: [hidden email]
> Subject: [ops-users] Re: Delete of Upload in Repeat causes incorrect UI
> update on the client.
>
>
> Nick,
>
>
> Nick_Van_den_Bleeken-2 wrote:
> >
> > The UI on the client is incorrectly updated when you delete an upload
> > control from a repeat.
> >
> > To reproduce this:
> >
> > 1. open the 'xforms-upload' sample app
> > (http://localhost:8080/orbeon/xforms-upload/ or
> > http://www.orbeon.com/ops/xforms-upload/ )
> >
> > 2. select 3 different files
> >
> > 3. hit the delete button on the second row
> >
> > 4. You will now see that the last (third) row seems to be
> deleted,
> >
>
> I was unable to reproduce this. I selected 3 files (1.html, 2.html, and
> 3.html) and after I press on the delete button in the second row I see
> that only the 1st and 3rd files are left. Have you managed to reproduce
> this with nightly builds?
>
> http://www.nabble.com/file/p22548500/after-delete.png
>
> Alex
>
> -----
> Orbeon Forms - Web 2.0 Forms, open-source, for the Enterprise Orbeon's
> Blog: http://www.orbeon.com/blog/ Personal Blog:
> http://avernet.blogspot.com/ Twitter - http://twitter.com/avernet
> --
> View this message in context: http://www.nabble.com/Delete-of-Upload-
> in-Repeat-causes-incorrect-UI-update-on-the-client.-
> tp22526462p22548500.html
> Sent from the ObjectWeb OPS - Users mailing list archive at Nabble.com.
>
>
> --
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
> --
>

Inventive Designers' Email Disclaimer:
http://www.inventivedesigners.com/email-disclaimer

--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
--

--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws

Nick Van den Bleeken

RE: RE: Re: Delete of Upload in Repeat causes incorrect UI update on the client.

Hi Alex,

The issue is less important to me now, I changed my form to submit the 'attachments' when they are selected using a send on the xforms-select event.

Regards,

Nick Van den Bleeken - Research & Development Manager
Inventive Designers
Phone: +32 - 3 - 8210170
Fax: +32 - 3 - 8210171
Email: [hidden email]

> -----Original Message-----
> From: Nick Van den Bleeken
> Sent: dinsdag 17 maart 2009 9:41
> To: [hidden email]
> Subject: [ops-users] RE: Re: Delete of Upload in Repeat causes
> incorrect UI update on the client.
>
> Hi Alex,
>
> Think you for the fast reply, I think I know what you are doing
> different then me. Can it be that you hit the Upload selected files
> before doing the delete of the second entry? It looks like this when I
> see your screen shot, and if I do this I can't reproduce the problem
> either.
>
> To reproduce the problem just select the three files, and then hit the
> delete button on the second row (without first hitting the Upload
> selected Files button)
>
> Regards,
>
> Nick Van den Bleeken - Research & Development Manager Inventive
> Designers
> Phone: +32 - 3 - 8210170
> Fax: +32 - 3 - 8210171
> Email: [hidden email]
>
> > -----Original Message-----
> > From: Alessandro Vernet [mailto:[hidden email]]
> > Sent: maandag 16 maart 2009 23:10
> > To: [hidden email]
> > Subject: [ops-users] Re: Delete of Upload in Repeat causes incorrect
> > UI update on the client.
> >
> >
> > Nick,
> >
> >
> > Nick_Van_den_Bleeken-2 wrote:
> > >
> > > The UI on the client is incorrectly updated when you delete an
> > > upload control from a repeat.
> > >
> > > To reproduce this:
> > >
> > > 1. open the 'xforms-upload' sample app
> > > (http://localhost:8080/orbeon/xforms-upload/ or
> > > http://www.orbeon.com/ops/xforms-upload/ )
> > >
> > > 2. select 3 different files
> > >
> > > 3. hit the delete button on the second row
> > >
> > > 4. You will now see that the last (third) row seems to be
> > deleted,
> > >
> >
> > I was unable to reproduce this. I selected 3 files (1.html, 2.html,
> > and
> > 3.html) and after I press on the delete button in the second row I
> see
> > that only the 1st and 3rd files are left. Have you managed to
> > reproduce this with nightly builds?
> >
> > http://www.nabble.com/file/p22548500/after-delete.png
> >
> > Alex
> >
> > -----
> > Orbeon Forms - Web 2.0 Forms, open-source, for the Enterprise
> Orbeon's
> > Blog: http://www.orbeon.com/blog/ Personal Blog:
> > http://avernet.blogspot.com/ Twitter - http://twitter.com/avernet
> > --
> > View this message in context: http://www.nabble.com/Delete-of-Upload-
> > in-Repeat-causes-incorrect-UI-update-on-the-client.-
> > tp22526462p22548500.html
> > Sent from the ObjectWeb OPS - Users mailing list archive at
> Nabble.com.
> >
> >
> > --
> > This message has been scanned for viruses and dangerous content by
> > MailScanner, and is believed to be clean.
> > --
> >
>
>
> Inventive Designers' Email Disclaimer:
> http://www.inventivedesigners.com/email-disclaimer
>
> --
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
> --
>

Alessandro Vernet

RE: Re: Delete of Upload in Repeat causes incorrect UI update on the client.

Administrator

In reply to this post by Nick Van den Bleeken

Hi Nick,

Nick_Van_den_Bleeken-2 wrote

To reproduce the problem just select the three files, and then hit the delete button on the second row (without first hitting the Upload selected Files button)

Ah, yes, I see. Indeed, it is a symptom of the same underlying issue you already linked to earlier in this thread.

I added a comment to that bug to mention this case as well. The issue is that while the server knows which iteration in the repeat is removed, the client doesn't. The server always tells the client "delete x items of this iteration" and the deletion is always done from the end. Then if values are shifted, the server will send the new values to the client. The issue here is that the server doesn't know yet the value for those fields. Maybe we'll need to enhance this system and enable the server to tell the client exactly which iteration of the repeat was removed.

Alex

Alessandro Vernet

RE: RE: Re: Delete of Upload in Repeat causes incorrect UI update on the client.

Administrator

In reply to this post by Nick Van den Bleeken

Nick,

Nick_Van_den_Bleeken-2 wrote

The issue is less important to me now, I changed my form to submit the 'attachments' when they are selected using a send on the xforms-select event.

Yes, for now, this is a good work-around.

Alex