Databound-select1 is not validated correctly

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Databound-select1 is not validated correctly

inanda.menezes
Hi,

I've used Databound-select1 xbl component in my forms, but it seems that there is a bug about the validation of this component.

It is showing the error text properly, but still the form validation passes. This makes possible to send empty selection values,even though the value is required.

I'm using Form Builder and orbeon 3.9, but I've also tested orbeon 3.9.1 and I got the same problem.

A sample form to reproduce the problem is attached to the topic.
databoundbug.xml

The following screenshot shows the error message, but the error summary component shows errors-count=0 and valid=true, even though the component is required and it is empty:




Reply | Threaded
Open this post in threaded view
|

Re: Databound-select1 is not validated correctly

Alessandro  Vernet
Administrator
Hi Inanda,

I think that I see what the problem is; I'll double check this tomorrow, and will post a follow-up then.

Alex
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet
Reply | Threaded
Open this post in threaded view
|

Re: Databound-select1 is not validated correctly

Alessandro  Vernet
Administrator
In reply to this post by inanda.menezes
Hi Inanda,

A quick update on this one: we made some progress, and determined a "deeper" cause for this issue. We'll continue the investigation and will update you when we have something new.

Alex
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet
Reply | Threaded
Open this post in threaded view
|

Re: Databound-select1 is not validated correctly

inanda.menezes
Ok, thank you.
Reply | Threaded
Open this post in threaded view
|

Re: Databound-select1 is not validated correctly

Alessandro  Vernet
Administrator
Hi Inanda,

Here we go: Erik fixed the underlying issue; the fix is now in the nightly builds, and will be in the next 4.0 milestone build. You'll let us know if this works for you.

https://github.com/orbeon/orbeon-forms/commit/394876aa86b2f16e4a353a7cde684fdced2059fc

Alex
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet
Reply | Threaded
Open this post in threaded view
|

Re: Databound-select1 is not validated correctly

inanda.menezes
Hi Alessandro,

It works fine. Now I just need to try to integrate these changes in version 3.9.0, because we are not planning to change the version for now.


Thanks a lot :)
Reply | Threaded
Open this post in threaded view
|

Re: Databound-select1 is not validated correctly

Alessandro  Vernet
Administrator
Hi Inanda,

That change will be very hard to backport to the 3.9 codebase, as a lot of the code this change touches has changed since then. So if you want this to work on 3.9, I'd recommend you just uncomment the following line in databound-select1.xbl. This is a workaround, but it will do the trick, and you'll get the "clean fix" when you upgrade to 4.0.

<xforms:action ev:event="#all" ev:propagate="stop"/>

Alex
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet