paging in datatable seems to be broken in Orbeon 4.4

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

paging in datatable seems to be broken in Orbeon 4.4

Heinrich Götzger
This post was updated on .
Hello guys,

I know, the beautiful datatable is deprecated in orbeon 4, but is this
the reason that paging is not working any longer?

Using the following example shows the problem using orbeon Orbeon Forms
4.4.0.201311042001 CE.
It used to work with Orbeon Forms 3.9.0.201105152046-CE.

<?xml version="1.0" encoding="UTF-8"?>
<xh:html
    xmlns:xf="http://www.w3.org/2002/xforms"
    xmlns:fr="http://orbeon.org/oxf/xml/form-runner"
    xmlns:xh="http://www.w3.org/1999/xhtml">

    <xh:head>
       <xf:model>
          <xf:instance id="items">
             <items>
                <item>0</item>
                <item>1</item>
                <item>2</item>
                <item>3</item>
                <item>4</item>
                <item>5</item>
                <item>6</item>
                <item>7</item>
                <item>8</item>
                <item>9</item>

                <item>10</item>
                <item>11</item>
                <item>12</item>
                <item>13</item>
                <item>14</item>
                <item>15</item>
                <item>16</item>
                <item>17</item>
                <item>18</item>
                <item>19</item>

                <item>20</item>
                <item>21</item>
                <item>22</item>
                <item>23</item>
                <item>24</item>
                <item>25</item>
                <item>26</item>
                <item>27</item>
                <item>28</item>
                <item>29</item>
             </items>
          </xf:instance>
       </xf:model>
    </xh:head>

    <xh:body>

       <xf:output ref="count(item)">
          <xf:label>
             No of items:
          </xf:label>
       </xf:output>

       <fr:datatable paginated="true">
          <xh:thead>
             <xh:tr>
                <xh:th>
                   item
                </xh:th>
             </xh:tr>
          </xh:thead>

          <xh:tbody>
             <xh:tr repeat-nodeset="item">
                <xh:td>
                   <xf:output
                      type="text"
                      ref="."/>
                </xh:td>
             </xh:tr>
          </xh:tbody>
       </fr:datatable>

       

    </xh:body>
</xh:html>


Where exactly the paging rows are calculated, how can we get this
running again?
Is it worth opening an issue about that?

Thanks a lot.

Cheers

Heinrich

--
Before printing this e-mail, think about our environmental responsibility.

--
You received this message because you are subscribed to the Google Groups "Orbeon Forms" group.
To unsubscribe from this group and stop receiving emails from it, send an email to orbeon+unsubscribe@googlegroups.com.
To post to this group, send email to orbeon@googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: paging in datatable seems to be broken in Orbeon 4.4

Alessandro  Vernet
Administrator
Hi Heinrich,

It isn't worth creating an issue, as we unfortunately don't have the bandwidth to fix this, and this, combine with the lack of demand from customers, is the reason why we deprecated it. However, the code is there: the meat of it is in JavaScript and it is in its separate directory, so it should really be possible for you to look into it yourself if you'd like.

https://github.com/orbeon/orbeon-forms/tree/master/src/resources-packaged/xbl/orbeon/datatable

And of course, just let us know if you have any issue along the way.

Alex
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet
Reply | Threaded
Open this post in threaded view
|

Re: paging in datatable seems to be broken in Orbeon 4.4 -- use external paging

Heinrich Götzger
Good Morning Alex,

thanks for your answer. We decided to use external paging now. It seems
to be more obvious what to do and we have full control in case of orbeon
updates.

The example of the datatable of the initial posting extended by external
paging is here:
https://gist.github.com/hgoetzger/9387531

Comments are welcome.

Regards

Heinrich

--
You received this message because you are subscribed to the Google Groups "Orbeon Forms" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Reply | Threaded
Open this post in threaded view
|

Re: paging in datatable seems to be broken in Orbeon 4.4 -- use external paging

Erik Bruchez
Administrator
Heinrich,

And by the way, and sorry to be a pain with this, but we are removing fr:datatable from Orbeon Forms 4.5. This doesn't mean you can't keep using it, you'll just have to copy over the XBL component from 4.4. But at least this should make it clearer that the component is not supported anymore.

-Erik
Reply | Threaded
Open this post in threaded view
|

Re: paging in datatable seems to be broken in Orbeon 4.4 -- use external paging

Heinrich Götzger
Hoi Erik,

this is really bad news. But thanks for announcing it. Actually I was
expecting this step not before release 5.
As I wrote earlier, we using fr:datatable quite often in almost every of
our forms.

When do you plan to release 4.5?

Regards

Heinrich

--
You received this message because you are subscribed to the Google Groups "Orbeon Forms" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Reply | Threaded
Open this post in threaded view
|

No datable anymore (Re: paging in datatable seems to be broken in Orbeon 4.4 -- use external paging)

Eric van der Vlist
Hi,

Some thoughts about the end of life of the datatable...

I understand Orbeon's decision but, as the original developer behind
this component, it makes me feel a little bit sad ;) ...

Developing this component, with all the browser interoperability issues
you can imagine has been a nightmare and its maintenance must have been
still harder.

That being said I think that 80% to 90% of the issues were due to
features that can (arguably) be considered cosmetic (resizeable columns
being a good example of such features).

I don't know if there would be a real interest for that but implementing
a simpler component (a "fr:basic-datatable", "fr:simple-datatable" or
maybe just "fr:table" component) which would be similar to what you can
see in Form Runner home page (http://demo.orbeon.com/orbeon/fr/ ) or
Form Builder summary pages
(http://demo.orbeon.com/orbeon/fr/orbeon/builder/summary ) would be much
easier and sortable columns would probably be quite easy to add.

Another option would be to see if the fr:grid component which is used
for repeated content by Form Runner/Form Builder couldn't be documented
and enhanced to be usable in a wider context.

fr:grid can also display XForms control in tables, has many features
which the datatable didn't have and can be used not only to display
tables but also to edit them (rows can be added, removed,
reordered, ...).

fr:grid is one of the most fundamental components for FR/FB, it is
actively used and supported by Orbeon and shouldn't be deprecated any
time soon ;) ...

Another thing I would do differently is paging: paging can be
interesting out of the scope of datatables and I think that a separate
"fr:pager" component which could embed not only datatables but any other
XForms repeat (with similar features) would be a better design IMO.

My 0.02 €

Eric

Le vendredi 07 mars 2014 à 14:41 +0100, Heinrich Götzger a écrit :

> Hoi Erik,
>
> this is really bad news. But thanks for announcing it. Actually I was
> expecting this step not before release 5.
> As I wrote earlier, we using fr:datatable quite often in almost every of
> our forms.
>
> When do you plan to release 4.5?
>
> Regards
>
> Heinrich
>


--
You received this message because you are subscribed to the Google Groups "Orbeon Forms" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Reply | Threaded
Open this post in threaded view
|

Re: paging in datatable seems to be broken in Orbeon 4.4 -- use external paging

Erik Bruchez
Administrator
In reply to this post by Heinrich Götzger
Heinrich,

For you, besides placing the 4.4 fr:datatable files under your WEB-INF/resources/xbl, nothing should  change. After all the datatable was designed as a modular UI component.

We feel bad about removing it but we feel also bad shipping unmaintained software. If somebody steps up to maintain it and test it, of course, we could put it back.

4.5 is in "ASAP" status right now ;)

(BTW We haven't decided yet if or when we would change the major number from 4 to 5.)

-Erik
Reply | Threaded
Open this post in threaded view
|

Re: No datable anymore (Re: paging in datatable seems to be broken in Orbeon 4.4 -- use external paging)

Erik Bruchez
Administrator
In reply to this post by Eric van der Vlist
Eric,

I think I understand how you feel ;)

It's not that there is no need for a datatable component, of course: it's a great feature. It just needs ongoing love.

Good comments: it would make sense to add paging to fr:grid, and the paging logic should ideally be separate!

-Erik
Reply | Threaded
Open this post in threaded view
|

Re: paging in datatable seems to be broken in Orbeon 4.4 -- use external paging

Heinrich Götzger
In reply to this post by Erik Bruchez
Erik,

well, yes, we'll see what to do. Extracting fr:datatable next to our own
components is an easy one, hopefully.
And, yes, I understand your point of view about maintenance.

So we look forward to get 4.5 for IE11 support, on the other hand, we're
almost finished the upgrade from 3.9 to 4.4 ...

Thanks

Regards

Heinrich

--
You received this message because you are subscribed to the Google Groups "Orbeon Forms" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Reply | Threaded
Open this post in threaded view
|

Re: paging in datatable seems to be broken in Orbeon 4.4 -- use external paging

Alessandro  Vernet
Administrator
Hi Heinrich,

Heinrich Götzger wrote
So we look forward to get 4.5 for IE11 support, on the other hand, we're
almost finished the upgrade from 3.9 to 4.4 ...
If it's any comfort, I really think that the upgrade from 4.4 to 4.5 will be much easier compared to what you did going from 3.9 to 4.4. (And BTW, congratulations on making it!)

Alex
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet
Reply | Threaded
Open this post in threaded view
|

Re: paging in datatable seems to be broken in Orbeon 4.4 -- use external paging

fritz
In reply to this post by Erik Bruchez
Hi Erik,
as we have many forms where datatable is mandatory  for form use, I've followed your idea to get datatable working
on 4.5.
I've moved files from 4.4 jars (public and private) to web-inf/resources/xbl/orbeon/datatable but looks like something
is still missing. (Maybe css is broken or I need something more in that folder from yui ?)

this is what I get  :



Have someone any idea about it?

Reply | Threaded
Open this post in threaded view
|

Re: paging in datatable seems to be broken in Orbeon 4.4 -- use external paging

Alessandro  Vernet
Administrator
You moved all the files from this directory, including the subdirectories, right?

https://github.com/orbeon/orbeon-forms/tree/tag-release-4.4-ce/src/resources-packaged/xbl/orbeon/datatable

Alex
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet
Reply | Threaded
Open this post in threaded view
|

Re: paging in datatable seems to be broken in Orbeon 4.4 -- use external paging

fritz
My bad, it was only a browser cache problem.

Fritz
Reply | Threaded
Open this post in threaded view
|

Re: paging in datatable seems to be broken in Orbeon 4.4 -- use external paging

Erik Bruchez
Administrator
Glad it's working now. -Erik