Orbeon 2018.1 code-mirror supports italic, but yui overrules

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Orbeon 2018.1 code-mirror supports italic, but yui overrules

ahenket
I was adding a release note using the code-mirror widget and made some stuff italic. In the editor this works fine, but when it comes back and is rendered in an xforms:output, the italics are overruled by some yui css.

.yui-navset li em {
    font-style: normal;
}

is overruling

.orbeon em {
    font-style: italic;
}

This looks like a (tiny) CSS bug to me. As far as I can find, both instructions are not mine to fix, although I could add another override in our own CSS to workaround this. The screenshot demonstrates in more detail what I'm seeing.

Could this be fixed in a future version?

--
You received this message because you are subscribed to the Google Groups "Orbeon Forms" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].

Schermafbeelding 2019-03-13 om 15.40.49.png (691K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Orbeon 2018.1 code-mirror supports italic, but yui overrules

Alessandro  Vernet
Administrator
Hi Alexander,

Could you share with us a minimal XForms file that reproduces the problem?
Things are working out for me using the attached `view.xhtml`.

‑Alex

view.xhtml <http://discuss.orbeon.com/file/t119778/view.xhtml>  

-----
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet
--
Sent from: http://discuss.orbeon.com/

--
You received this message because you are subscribed to the Google Groups "Orbeon Forms" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet
Reply | Threaded
Open this post in threaded view
|

Re: Orbeon 2018.1 code-mirror supports italic, but yui overrules

Alessandro  Vernet
Administrator
Hi Alexander, have figured out why the italic text produced by the `xf:output
mediatype="text/html"` in your case gets overridden by some YUI CSS? If not,
would you maybe be able to create an example that I could run here to
reproduce the issue?

‑Alex

-----
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet
--
Sent from: http://discuss.orbeon.com/

--
You received this message because you are subscribed to the Google Groups "Orbeon Forms" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet
Reply | Threaded
Open this post in threaded view
|

Re: Orbeon 2018.1 code-mirror supports italic, but yui overrules

ahenket
Hi. It slipped off my radar so thanks for reminding. I've used your view.xhtml as basis and extended it for reproduction.

The phenomenon is reproducible for <em>...</em> under an fr:tab and an xh:li element. Only in that combination. The very same instance can be rendered fine outside of the fr:tab.

--
You received this message because you are subscribed to the Google Groups "Orbeon Forms" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].

view.xhtml (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Orbeon 2018.1 code-mirror supports italic, but yui overrules

Alessandro  Vernet
Administrator
Hi Alexander,

I see:  world-not-italic-when-in-tab-li.png
<http://discuss.orbeon.com/file/t119778/world-not-italic-when-in-tab-li.png>  

As you said, the problem is with the `.yui-navset li em { font-style:
normal; }` in `tabview.css`. I think they could have targeted `.yui-navset
.yui-nav` instead of just `.yui-navset`, as it looks to me that they just
wanted to make the title of the tab non-italic. At this point, we are not
maintaining anymore the `fr:tabview` component, and instead use and maintain
the `fr:tabbable` component. So we're not going to patch YUI, or add CSS to
the `fr:tabview` to fix this. Hence, I'd suggest you get around this either:

1. By adding `.yui-navset .yui-content li em { font-style: italic; }` to
your own CSS. This is most likely the simplest solution.
2. By switching from the `fr:tabview` to the `fr:tabbable` component.

You'll let me know if one of those 2 options works for you, or if you've
maybe already found a solution to this one.

‑Alex

-----
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet
--
Sent from: http://discuss.orbeon.com/

--
You received this message because you are subscribed to the Google Groups "Orbeon Forms" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet