Datatable format is lost when hiding and re-displaying datatables within a nested structure

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Datatable format is lost when hiding and re-displaying datatables within a nested structure

Philip.Cantin
Erik/Alex,

I believe I may have found a bug related to the datatables, which is present in the latest (10-23-2009) nightly build, and was also present in the build I'm currently working with (8-14-2009).

When datatables are hidden and re-displayed through the use of <xf:group> statements, the format, for all datatables that are deeper than the current element where the show/hide trigger was called, is lost.

I've attached a reproducible example to this message. To reproduce:

1) Download the example, place in the 'WEB-INF/resources/apps' folder, and run. All datatables in the form are currently fine.
2) Press the 'Hide Controls' button, and then press the 'Show Controls' button. The first datatable is fine, but the others deeper within the XML structure lose their formatting.
3) Now press the 'Reload Page' button. The form reloads, and everything is back to normal.
4) In page_flow.xml, change "standardxform.xhtml" to "standardxform_no_xbl.xhtml" and repeat steps 1-3. This is just to show that the bug occurs even when XBL components aren't used (except the datatable, of course).


If something is incorrect, please let me know. Thanks!


---Philip


xforms-datatable-test.zip
Reply | Threaded
Open this post in threaded view
|

Re: Datatable format is lost when hiding and re-displaying datatables within a nested structure

Alessandro  Vernet
Administrator
Philip,

On Fri, Oct 23, 2009 at 1:03 PM, Philip.Cantin <[hidden email]> wrote:
> 2) Press the 'Hide Controls' button, and then press the 'Show Controls'
> button. The first datatable is fine, but the others deeper within the XML
> structure lose their formatting.

I have been able to reproduce this. A screencast for reference:

http://screencast.com/t/m76dh27uwW22

Alex
--
Orbeon Forms - Web forms, open-source, for the Enterprise
Orbeon's Blog: http://www.orbeon.com/blog/
My Twitter: http://twitter.com/avernet


--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet
Reply | Threaded
Open this post in threaded view
|

Re: Datatable format is lost when hiding and re-displaying datatables within a nested structure

Alessandro  Vernet
Administrator
On Fri, Oct 23, 2009 at 2:43 PM, Alessandro Vernet <[hidden email]> wrote:
> I have been able to reproduce this. A screencast for reference:
>
> http://screencast.com/t/m76dh27uwW22

And the bug for this is:

http://forge.ow2.org/tracker/index.php?func=detail&aid=314415&group_id=168&atid=350207

Alex
--
Orbeon Forms - Web forms, open-source, for the Enterprise
Orbeon's Blog: http://www.orbeon.com/blog/
My Twitter: http://twitter.com/avernet


--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws
--
Follow Orbeon on Twitter: @orbeon
Follow me on Twitter: @avernet
Reply | Threaded
Open this post in threaded view
|

Re: Re: Datatable format is lost when hiding and re-displaying datatables within a nested structure

Eric van der Vlist
Philip, Alex,

Good catch!

When a datatable is within an XForms repeat and when one of its
iterations is deleted and recreated, this iteration is physically
destroyed from the DOM and recreated. The iteration of the datatable
needs thus to be initialized again and the datatable implementation
failed to do so.

This is now fixed:

      * in the master branch
        http://github.com/orbeon/orbeon-forms/commit/c539065d47090d05307d4a1d56d6bff5b2fe39a4
      * in the development branch
        http://github.com/orbeon/orbeon-forms/commit/ce49d46a93e6ab2bd08cb1f85d90cf1eb781b7ea

Philip,

I have noticed that your XBL components generate errors on the
development branch because, under the new scoping rules, they generate
duplicate ids.

These scoping rules are documented under
http://wiki.orbeon.com/forms/doc/developer-guide/xbl-components-guide
and you may want to have a look: as they are now, they will stop working
as soon as the development branch will have been merged into master!

Thanks for your report.

Eric

--
Eric van der Vlist <[hidden email]>
Dyomedea (http://dyomedea.com)



--
You receive this message as a subscriber of the [hidden email] mailing list.
To unsubscribe: mailto:[hidden email]
For general help: mailto:[hidden email]?subject=help
OW2 mailing lists service home page: http://www.ow2.org/wws